Add support for defaultModel config #955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mludvig
requested review from
Yukinobu-Mine,
statefb and
wadabee
as code owners
statefb
reviewed
Oct 21, 2025
| return [] | ||
|
|
||
|
|
||
| def get_default_model() -> type_model_name: |
There was a problem hiding this comment.
As you suggested, there are several "default models" on this application:
- Title generation
- New chat screen
- etc
Why don't we have get_default_model which returns BaseSchema? e.g.
class DefaultModelSchema(BaseSchema):
title_generation_model: type_model_name
chat_model: type_model_name
# ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change some model names were hardcoded in the codebase - claude-v3-haiku for generating the convo titles and claude-v3.7-sonnet as the default for everything else. The problem is that some accounts may not have access to these models and changing them is not trivial for the end users.
This PR adds a new config option
defaultModelfor setting this default model in cdk.json / parameter.ts so that the default model can be easily updated, perhaps along withglobalAvailableModels.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.