update: Re-instated FSxN lab #1259
Conversation
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mickeysh
changed the title
niallthomson
changed the title
There was a problem hiding this comment.
Thanks for the PR @mickeysh
The main thing I think is missing is a cleanup.sh script as seen here. It will need to basically unwind every command the user does during your lab (uninstall helm chart, cleanup Kubernetes resource etc). See EFS version:
Some other smaller comments added inline.
lab/iam/policies/labs4.yaml
Outdated
| - fsx:ListTagsForResource | ||
| Resource: | ||
| - ["*"] | ||
| - Effect: Allow |
There was a problem hiding this comment.
We should be able to consolidate these permissions in to the secretsmanager ones in labs1.yaml so we aren't spreading permissions for the same service over multiple files.
| Statement: | ||
| - Effect: Allow | ||
| Action: | ||
| - fsx:CreateFileSystem |
There was a problem hiding this comment.
Is it possible to lock some of these down a little bit, for example using RequestTag like here
…, add tag conditions for FSxN IAM resources
What this PR does / why we need it:
Which issue(s) this PR fixes:
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.