Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: PR for Korean language #1265

Closed
wants to merge 1 commit into from
Closed

Conversation

jinoos
Copy link

@jinoos jinoos commented Feb 17, 2025

What this PR does / why we need it:

This PR provides Korean translations for all Workshop documents to improve accessibility for Korean users.

Which issue(s) this PR fixes:

None.

Requires to author

I haven't modified website/docusaurus.config.js file, due to not comprehend any other impact.
website/docusaurus.config.js should be like below.

  i18n: {
    defaultLocale: 'en',
    locales: ['en', 'kr'],
    localeConfigs: {
      en: {
        htmlLang: 'en-US',
        // for current path
        path: 'docs',
      },
      kr: {
        htmlLang: 'ko-KR',
        // by this PR
        path: 'i18n/kr',
      },
    },
  },

And, I have checked and tested by below dev mode without docusaurus.config.js change.

npm run start -- --locale kr

Please let me know if you need any opinion about this PR applying.

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit 1599a93
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/67b2d50c09208c0008e67d6d
😎 Deploy Preview https://deploy-preview-1265--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niallthomson
Copy link
Contributor

Hi @jinoos we're currently discussing this PR internally. Will respond soon.

@niallthomson
Copy link
Contributor

Closing this in favor of discussing in #1398 since we'll need a repeatable process to handle translating content every month as updates are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants