Skip to content

fix: Firefox textarea scrolling issues due to incorrect height calculation #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025

Conversation

toshikwa
Copy link
Collaborator

Description of Changes

This pull request addresses an issue with height calculation in Firefox.

Changes:

  • Added a Firefox-specific workaround to force layout recalculation before measuring scroll height
  • Improved keyboard event handling by using React's built-in onKeyDown property
  • Replaced useEffect with useLayoutEffect for better synchronization with the rendering cycle

Checklist

  • Modified relevant documentation
  • Verified operation in local environment
  • Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

Please list related issues as much as possible.

@tbrand tbrand merged commit 526ddee into main Jun 2, 2025
2 checks passed
@tbrand tbrand deleted the fix/firefox-scroll-height branch June 2, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants