Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kb resources with sonnet and YML file for cloudformation #6

Merged
merged 4 commits into from
May 29, 2024

Conversation

lifeth
Copy link
Contributor

@lifeth lifeth commented May 24, 2024

Issue #, if available:

Description of changes:

  • Cloudformation template YML
  • Knowledge base resources
  • upgrade to Claude Sonnet

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@KBB99
Copy link
Contributor

KBB99 commented May 27, 2024

This looks great! Can we make the knowledge base deployment conditional based on a. parameter though?

@lifeth
Copy link
Contributor Author

lifeth commented May 27, 2024

This looks great! Can we make the knowledge base deployment conditional based on a. parameter though?

This looks great! Can we make the knowledge base deployment conditional based on a. parameter though?

Hola! I added one condition for that in the ai-stack.ts file

if (!knowledge_base_id) { ....

Is that enough? or are you thinking about another parameter?

@KBB99 KBB99 merged commit 76ad0f2 into aws-samples:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants