Allow rotation transformation without angle argument #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related: github.com//issues/495
Description of changes:
This change enables the
rotate
filter to be used without an angle argument (e.g.,filters:rotate()
). The previous implementation would parse this as0
and pass it tosharp.rotate()
.The new implementation takes advantage of Sharp's behavior when
rotate()
is called without arguments:Orientation
tag after applying the rotationThis change helps fix issues with images that contain EXIF orientation metadata but are displayed incorrectly in clients (e.g., browsers) that don't support EXIF orientation.
Reference: Sharp Documentation - rotate
Note: I have verified that the change works as expected, but additional unit tests may be needed to ensure proper coverage.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.