[Pending manual FIPS testing] Fix ECR Client Migration to V2 #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheanLim
changed the title
TheanLim
changed the title
TheanLim
force-pushed
the
fix-ecr-migration
branch
from
8cf4edb to
d672034
Compare
mye956
reviewed
Apr 4, 2025
| ) | ||
|
|
||
| const httpsPrefix = "https://" |
There was a problem hiding this comment.
Q: Do we also need to consider http as well?
Looks like in AWS SDK Go V1, it takes that into consideration when appending the prefixes -> https://github.com/aws/aws-sdk-go/blob/8d203ccff393340d080be0417d091cc60354449b/aws/endpoints/endpoints.go#L324-L339
There was a problem hiding this comment.
No, we don't need to consider http.
We currently (in v1) do not instantiate a new client with Config.DisableSSL set to true. This flag is passed to AddScheme to determine whether the HTTP or HTTPS schemes should be added.
In short, we only prepend https prefix, if it's needed.
TheanLim
force-pushed
the
fix-ecr-migration
branch
from
d672034 to
8f62fed
Compare
added 2 commits
April 10, 2025 14:53
TheanLim
force-pushed
the
fix-ecr-migration
branch
from
48399a7 to
5fd8b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A fix on PR #4512 by adding HTTPS prefix.
Implementation details
HTTPS/HTTP prefix is automatically added to
endpointin sdk v1 but not in v2.Adding HTTPS prefix to endpoint override if it's not already so.
Testing
New tests cover the changes: no, but adapting the existing test.
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.