Conversation
4e8633c to
4526c7a
Compare
harishxr
approved these changes
Apr 18, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes container and task metadata v4 responses include IPv6 container addresses for bridge mode tasks. IPv6 addresses are already included for awsvpc mode tasks. This change extends that functionality to bridge mode tasks as we prepare for IPv6-only support.
Testing
New tests cover the changes: yes
Ran a bridge mode task on an instance with IPv6 enabled on the bridge network and observed the response of TMDS v4 container metadata endpoint.
Did the same for v4 task metadata -
Also verified that v3 metadata endpoints do not return IPv6 addresses. Note that v2 metadata endpoints are not supported for bridge mode tasks.
Also verified that v4 metadata response is unchanged for
hostnetwork mode tasks as they do not have any container IP addresses.Description for the changelog
Enhancement: Include container IPv6 addresses (if available) in container and task metadata v4 responses for bridge mode tasks.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.