[SeamlessDomainJoin] Ubuntu - Retrieve and set interface name dynamically#499
Open
jaseblenner wants to merge 1 commit intoaws:mainlinefrom
Open
[SeamlessDomainJoin] Ubuntu - Retrieve and set interface name dynamically#499jaseblenner wants to merge 1 commit intoaws:mainlinefrom
jaseblenner wants to merge 1 commit intoaws:mainlinefrom
Conversation
Contributor
|
Thanks for this PR, @jaseblenner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeamlessDomainJoin has been configured to retrieve interface name dynamically everywhere but the
do_dns_configfunctionIssue #, if available:
469
Description of changes:
As per issue 469 newer tX (t3 and above) EC2 instances now use interface names of
ensXas opposed toeth0Issue #469 / PR #470 has been opened and merged to remediate this however the
do_dns_configfunction needs to be added to configure the interface name dynamically also. This PR/merge request handles this and has been tested.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.