feat: srw #1048
Open
feat: srw #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Dec 4, 2025
aws_advanced_python_wrapper/simple_read_write_splitting_plugin.py
Outdated
Show resolved
Hide resolved
aaron-congo
reviewed
Dec 12, 2025
| ... | ||
|
|
||
| def is_reader_host(self, current_host: HostInfo) -> bool: | ||
| """Return true if the current host fits the criteria of a writer host.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Return true if the current host fits the criteria of a writer host.""" | |
| """Return true if the current host fits the criteria of a reader host.""" |
Comment on lines
+497
to
+498
| def old_reader_can_be_used(self, reader_host_info: HostInfo) -> bool: | ||
| """Return true if the current host can be used to switch connection to.""" |
Contributor
There was a problem hiding this comment.
I know we only pass a reader host into this method but there's no logic specific to readers. I don't think this method needs to know whether the host info is new or old, writer or reader.
Suggested change
| def old_reader_can_be_used(self, reader_host_info: HostInfo) -> bool: | |
| """Return true if the current host can be used to switch connection to.""" | |
| def can_host_be_used(self, host_info: HostInfo) -> bool: | |
| """Returns true if connections can be switched to the given host""" |
Comment on lines
+501
to
+502
| def need_connect_to_writer(self) -> bool: | ||
| """Return true if switching to reader should instead connect to writer.""" |
Contributor
There was a problem hiding this comment.
I think this would make things a bit clearer
Suggested change
| def need_connect_to_writer(self) -> bool: | |
| """Return true if switching to reader should instead connect to writer.""" | |
| def has_no_readers(self) -> bool: | |
| """Return true if there are no readers in the host list""" |
| WrapperProperties.SRW_CONNECT_RETRY_INTERVAL_MS, props, int, lambda x: x > 0 | ||
| ) | ||
|
|
||
| self._verify_opened_connection_type: Optional[HostRole] = ( |
Contributor
There was a problem hiding this comment.
I think this will make it clearer that this is for initial connections, not subsequent connection switches
Suggested change
| self._verify_opened_connection_type: Optional[HostRole] = ( | |
| self._verify_initial_connection_type: Optional[HostRole] = ( |
| try: | ||
| if connect_func is not None: | ||
| candidate_conn = connect_func() | ||
| elif host_info is not None: |
Contributor
There was a problem hiding this comment.
is this check necessary if host_info is not Optional? Or should host_info be of type Optional[HostInfo]?
| sleep(self._connect_retry_interval_ms / 1000) | ||
|
|
||
| @staticmethod | ||
| def _parse_connection_type(phase_str: Optional[str]) -> HostRole: |
Contributor
There was a problem hiding this comment.
Why do we use the word "phase"? would "expected_role" work?
Suggested change
| def _parse_connection_type(phase_str: Optional[str]) -> HostRole: | |
| def _parse_role(role_str: Optional[str]) -> HostRole: |
| if not phase_str: | ||
| return HostRole.UNKNOWN | ||
|
|
||
| phase_upper = phase_str.lower() |
Contributor
There was a problem hiding this comment.
Suggested change
| phase_upper = phase_str.lower() | |
| phase_lower = phase_str.lower() |
aaron-congo
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.