feat(cli): support notification-arns in cdk import#1740
Open
lemon0333 wants to merge 2 commits into
Open
Conversation
An import is executed through the same CloudFormation change-set machinery as a deployment, and the deployment layer already supports notification ARNs. This exposes the --notification-arns option on the import command, merging and validating the ARNs with the same semantics as cdk deploy before forwarding them to the change set. Closes aws/aws-cdk#23548
aws-cdk-automation
enabled auto-merge
July 18, 2026 14:45
lemon0333
requested a deployment
to
integ-approval
July 18, 2026 14:45 — with
GitHub Actions
Waiting
2 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
==========================================
+ Coverage 89.57% 90.17% +0.60%
==========================================
Files 78 78
Lines 11790 11821 +31
Branches 1655 1673 +18
==========================================
+ Hits 10561 10660 +99
+ Misses 1200 1130 -70
- Partials 29 31 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes aws/aws-cdk#23548
Adds the
--notification-arnsoption tocdk import, matchingcdk deploy.An import runs through the same CloudFormation change-set machinery as a deployment, and the deployment layer (
Deployments.deployStack()) already supports notification ARNs — this change exposes the option on the import command and threads it through:cli-config.ts: newnotification-arnsoption onimport(generated CLI argument files regenerated by the build)CdkToolkit.import(): merges with the stack'snotificationArnsand validates each ARN, reusing the exact semantics ofcdk deploy(undefined= keep existing / externally managed,[]= clear,['arn']= set)ImportDeploymentOptions: new optionalnotificationArnsfield, forwarded todeployStack()Tests mirror the existing deploy notification-arns coverage: CLI argument forwarding, toolkit-level merge/validation, and
NotificationARNsreaching the CreateChangeSet call.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license