Skip to content

Conversation

@pahud
Copy link
Contributor

@pahud pahud commented Nov 13, 2025

We have seen many requests from the contributors asking for what's next to move forward the PR review such as

#35933 (comment)
#35819 (comment)
#35812 (comment)
#35773 (comment)
#35766 (comment)
#34202 (comment)

We need to add a section in the contributing guide about "what should we do/expect after the PR submission".

This PR essentially:

  • Add new section "What Happens After You Submit Your PR" to CONTRIBUTING.md
  • Describe CodeBuild CI validation process and steps for resolving build failures
  • Explain community review queue and requirements for community review
  • Detail maintainer review process and progression of PR through review stages
  • Provide guidance on monitoring PR status and addressing potential issues
  • Improve documentation to help contributors understand the PR submission workflow

Issue # (if applicable)

Closes #.

Reason for this change

To improve the contributing experience.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- Add new section "What Happens After You Submit Your PR" to CONTRIBUTING.md
- Describe CodeBuild CI validation process and steps for resolving build failures
- Explain community review queue and requirements for community review
- Detail maintainer review process and progression of PR through review stages
- Provide guidance on monitoring PR status and addressing potential issues
- Improve documentation to help contributors understand the PR submission workflow
@github-actions github-actions bot added the p2 label Nov 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 13, 2025 16:02
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 13, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@pahud pahud changed the title docs(contributing): Add section explaining PR review process docs(contributing): add section explaining PR review process Nov 13, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 13, 2025 16:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

- Modify text to clarify that a community review moves PR to maintainer review queue
- Refine language around community review requirements
- Improve precision of contribution workflow documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants