fix(eks): inconsistent fargateProfileName handling causes deletion failure when physicalResourceId exceeds 100 characters #36075
+131
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #32909.
Reason for this change
When deleting an EKS FargateProfile, the
onDeleteevent directly usesphysicalResourceIdas the profile name without validating its length. IfphysicalResourceIdexceeds 100 characters (AWS EKS's maximum limit), deletion fails with: "The Fargate profile name parameter should not be greater than 100 characters."The
onCreateevent already handles this by generating a valid name when needed, but this logic was missing inonDelete.Description of changes
Updated
onDelete()to use the same name resolution logic asonCreate():fargateProfileNameis explicitly provided in config: use itphysicalResourceIdis valid (≤ 100 chars): use it directlyphysicalResourceIdexceeds 100 chars: generate a name usinggenerateProfileName()Files changed:
fargate.ts: UpdatedonDelete()methodfargate-resource-provider.test.ts: Added 5 unit tests covering all scenariosDescription of how you validated changes
Added comprehensive unit tests:
physicalResourceIdfargateProfileNamehandlingphysicalResourceId> 100 charsAll tests pass:
yarn test fargate-resource-provider.test.tsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license