[v2] Merge v2 into lazy-plugin-initialization#10392
Conversation
Update README zsh completion to match User Guide Both pip and bundled installs ship aws_completer, so a single set of instructions covers both methods. Replace the legacy aws_zsh_completer.sh block with bashcompinit + complete -C aws_completer as documented in the AWS CLI User Guide: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-completion.html Fixes #8957
…I coding agents (#10383) * Add agent-toolkit feature for installing AWS skills and configuring AI coding agents
…placed it with instance variable.
| self.load_registry(self._registry) | ||
|
|
||
| def load_registry(self, registry): | ||
| self._registry = registry |
There was a problem hiding this comment.
Not sure I understand what this is for? I see that in the init, a registry can be provided, which is set in self._registry. But then this resets it? Why does it need to be set in the init (line 52)?
There was a problem hiding this comment.
We don't actually pass in a registry to the init function, we only pass it to load_registry. The only place we pass it to the init function is in test suites.
There was a problem hiding this comment.
Ah, I see the confusion in my wording. Init accepts a plugin registry. We don't pass the registry to init during construction in the CLI codebase (non-tests), instead we only pass the registry during calling load_registry. We only pass the registry to init in our test suites.
5 participants
Description of changes:
v2intolazy-plugin-initialization:agent-toolkitcustomization to the new handlers_registry system. Updated file in merge commit:awscli/handlers_registry.py.Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.