Skip to content

[v2] Add Session IDs to User-Agent header even when cache does not exist#10398

Open
aemous wants to merge 1 commit into
v2from
bugfix/session-id-no-cache
Open

[v2] Add Session IDs to User-Agent header even when cache does not exist#10398
aemous wants to merge 1 commit into
v2from
bugfix/session-id-no-cache

Conversation

@aemous

@aemous aemous commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

  • CLI-8466 (internal)

Description of changes:

  • Fixed a bug where session IDs are added to the User-Agent HTTP header even when the local cache does not exist.
  • Modified CLISessionDatabaseConnection to allow a cache directory override to be passed in during initialization. This improves testability.
  • Added new regression test that verifies (1) local cache is created and (2) database connection succeeds when the local cache does not exist.

Description of tests:

  • IN PROGRESS Successfully ran all tests and the pre-production build workflow (see GitHub Actions).
  • TODO Run manual commands with the cache deleted beforehand, inspect the user agent header.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team as a code owner June 11, 2026 14:05
@aemous aemous added v2 pr:work-in-progress This PR is a draft and needs further work. labels Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:work-in-progress This PR is a draft and needs further work. v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant