Update new-change script enhancement description. #9475
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9475 +/- ##
========================================
Coverage 93.39% 93.40%
========================================
Files 210 211 +1
Lines 16983 17000 +17
========================================
+ Hits 15861 15878 +17
Misses 1122 1122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdaily
reviewed
May 2, 2025
Co-authored-by: Kenneth Daily <[email protected]>
kdaily
approved these changes
May 9, 2025
nateprewitt
reviewed
May 9, 2025
There was a problem hiding this comment.
It might be better to avoid the word "feature" here since it denotes a separate change above. Anything that's adding net-new functionality is fine as an enhancement as long as we're not making changes to fundamental systems. Those would prompt a version bump which is when feature is used.
Comment on lines
+60
to
+61
| # enhancement: Adding a small feature or a change to an underlying | ||
| implementation detail. |
There was a problem hiding this comment.
Suggested change
| # enhancement: Adding a small feature or a change to an underlying | |
| implementation detail. | |
| # enhancement: An incremental improvement or a change to an underlying | |
| implementation detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.