feat(dafny): KSA Create Key Operation for HV-2#1374
Merged
Conversation
texastony
changed the title
…ksa-operation # Conflicts: # AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStore/src/KMSKeystoreOperations.dfy # AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/AwsCryptographyKeyStoreAdminOperations.dfy # AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/MutateViaDecryptEncrypt.dfy # AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/Mutations.dfy
texastony
requested changes
Apr 2, 2025
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
I left some suggestions and one blocker;
I think this looks really good!
texastony
reviewed
Apr 2, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
Contributor
|
It looks like you are adding or removing the dafny keyword {:only}. |
texastony
approved these changes
Apr 4, 2025
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
We have a lot of TODOs left, but let's get this in, and focus on testing and running down the MRK issue.
imabhichow
added a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
Apr 9, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
Apr 9, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
Apr 13, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
Apr 13, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
Apr 14, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
May 21, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
added a commit
that referenced
this pull request
May 21, 2025
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.