Skip to content

chore: use install smithy dafny deps from MPL #2266

Merged
rishav-karanjit merged 8 commits into
mainfrom
reuse-install_smithy_dafny_codegen_dependencies-actions
May 12, 2026
Merged

chore: use install smithy dafny deps from MPL #2266
rishav-karanjit merged 8 commits into
mainfrom
reuse-install_smithy_dafny_codegen_dependencies-actions

Conversation

@rishav-karanjit
Copy link
Copy Markdown
Member

@rishav-karanjit rishav-karanjit commented May 7, 2026

Issue #, if available:

Description of changes:
We will reuse the action from MPL to avoid duplication across repositories to help us maintain the CI as we will have single source-of-truth.

Updated maintainers list in check-files.yml to add Bikram's username

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@rishav-karanjit rishav-karanjit marked this pull request as ready for review May 8, 2026 14:34
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner May 8, 2026 14:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

sharmabikram
sharmabikram previously approved these changes May 8, 2026
josecorella
josecorella previously approved these changes May 8, 2026
Copy link
Copy Markdown
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, but we probably should have just updated the install_smithy_dafny action to use the mpl instead; because we had to touch every single workflow

@rishav-karanjit rishav-karanjit dismissed stale reviews from josecorella and sharmabikram via fb9f4e2 May 11, 2026 20:01
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@aws aws deleted a comment from github-actions Bot May 11, 2026
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@rishav-karanjit rishav-karanjit merged commit 4f3b542 into main May 12, 2026
84 of 85 checks passed
@rishav-karanjit rishav-karanjit deleted the reuse-install_smithy_dafny_codegen_dependencies-actions branch May 12, 2026 07:06
ShubhamChaturvedi7 added a commit that referenced this pull request Jun 1, 2026
* chore(release): 4.0.0

* **java:** add DDBEC with SDK v2 and remove DDBEC with SDK V1 (#2048)
* **.net:** Bump MPL V2 (#2145)

* **java:** add DDBEC with SDK v2 and remove DDBEC with SDK V1 ([#2048](#2048)) ([035dbe3](035dbe3))

* **.net:** Bump MPL V2 ([#2145](#2145)) ([87c534b](87c534b))

* use UUIDs and cleanup in beacon styles example to avoid stale item collisions ([#2125](#2125)) ([773c1ff](773c1ff))

* **.net:** add ddb local to .net release ([#2075](#2075)) ([db55bdf](db55bdf))
* **.net:** comment out testvectors from release ([#2076](#2076)) ([fdaa9e3](fdaa9e3))
* **.net:** fix release commands to include all json tv files ([#2072](#2072)) ([10f809d](10f809d))
* **.net:** pin mpl to latest ([#2065](#2065)) ([f6b64a6](f6b64a6))
* **.net:** reference submoduled mpl ([#2080](#2080)) ([be3f58f](be3f58f))
* add retries to examples ([#2262](#2262)) ([ab622af](ab622af))
* add special-characters-workaround to avoid sigv4 failure ([#2270](#2270)) ([7223d98](7223d98))
* bump GitHub Actions to latest versions ([#2144](#2144)) ([92615d4](92615d4))
* **ci:** add concurrency control  ([#2265](#2265)) ([85d6be8](85d6be8))
* **ci:** add more error code in infra related failure ([#2254](#2254)) ([7d3b0b5](7d3b0b5))
* **ci:** Add retries to DDB local setup steps  ([#2267](#2267)) ([7987566](7987566))
* **ci:** add workflow_dispatch and remove run on PR for daily CI ([#2218](#2218)) ([d6fd0fb](d6fd0fb))
* **ci:** daily ci for branches ([#2208](#2208)) ([fcc4b97](fcc4b97))
* **ci:** fix Test Examples workflow for v3.x-java daily ci ([#2233](#2233)) ([0140037](0140037))
* **ci:** remove branch default to main ([#2219](#2219)) ([1a3d1f0](1a3d1f0))
* **ci:** retry failed CI only for infrastructure errors ([#2235](#2235)) ([909b34a](909b34a))
* **CI:** run clippy ([#2181](#2181)) ([6b54985](6b54985))
* **ci:** run test on Java 21 and windows OS ([#2159](#2159)) ([6e702d8](6e702d8))
* **ci:** Update daily_ci to get triggered at 7AM ([#2283](#2283)) ([3ed89b5](3ed89b5))
* **ci:** use snapshot builds ([#2083](#2083)) ([0124ca6](0124ca6))
* **deps:** bump actions/checkout v5->v6 and setup-docker-macos-action v1.0.2->v1.1.0 ([#2130](#2130)) ([337c776](337c776))
* **deps:** update aws-lc-sys requirement from 0.38 to 0.39 in /DynamoDbEncryption/runtimes/rust ([#2149](#2149)) ([b76bcb7](b76bcb7))
* refactor non-prod CI to only run Go targets ([#2134](#2134)) ([0d2622c](0d2622c))
* release aws-db-esdk v1.2.3 ([#2122](#2122)) ([888aaba](888aaba))
* **release:** 4.0.0 ([#2247](#2247)) ([ddf56bf](ddf56bf)), closes [#2048](#2048)
* **release:** allow local testing ([#2251](#2251)) ([546b68c](546b68c))
* run java test on ubuntu ([#2167](#2167)) ([cffa72c](cffa72c))
* separate changelog for Java and .NET ([#2242](#2242)) ([67ed551](67ed551))
* use install smithy dafny deps from MPL ([#2266](#2266)) ([4f3b542](4f3b542))

* chore: edit net changelog

* chore: pin mpl version as project ref

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Shubham Chaturvedi <scchatur@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants