Skip to content

BIO datagram functions #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2025
Merged

BIO datagram functions #2321

merged 9 commits into from
May 7, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 9, 2025

Issues:

Resolves CryptoAlg-3032

Description of changes:

Adds support for datagram (UDP) sockets to BIO. The implementation includes:

  • New BIO_s_datagram() method for creating datagram BIOs
  • Support for both connected and unconnected datagram sockets
  • IPv4, IPv6 and Unix domain socket support (where available)
  • Adds support for BIO_get_close

Call-outs:

N/A

Testing:

  • Added tests to cover new functionality.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 78.77238% with 83 lines in your changes missing coverage. Please review.

Project coverage is 78.80%. Comparing base (cddf0ec) to head (bbe156b).

Files with missing lines Patch % Lines
crypto/bio/bio_socket_test.cc 70.52% 36 Missing and 15 partials ⚠️
crypto/bio/dgram.c 84.80% 31 Missing ⚠️
crypto/bio/connect.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
+ Coverage   78.79%   78.80%   +0.01%     
==========================================
  Files         620      621       +1     
  Lines      108076   108415     +339     
  Branches    15347    15399      +52     
==========================================
+ Hits        85157    85441     +284     
- Misses      22261    22305      +44     
- Partials      658      669      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the BIO-datagram branch 6 times, most recently from 24038b8 to d03a57c Compare April 10, 2025 20:00
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@justsmth justsmth force-pushed the BIO-datagram branch 6 times, most recently from 2a602cd to 9ce3938 Compare April 12, 2025 00:53
@justsmth justsmth force-pushed the BIO-datagram branch 6 times, most recently from a7b1d0d to 90e4999 Compare April 22, 2025 16:04
@justsmth justsmth force-pushed the BIO-datagram branch 2 times, most recently from 7da9b81 to 63cc957 Compare April 30, 2025 11:59
@justsmth justsmth changed the title [DRAFT] BIO datagram functions BIO datagram functions Apr 30, 2025
@justsmth justsmth marked this pull request as ready for review April 30, 2025 16:45
@justsmth justsmth requested a review from a team as a code owner April 30, 2025 16:45
@justsmth justsmth requested review from smittals2 and removed request for samuel40791765 May 1, 2025 20:09
@justsmth justsmth merged commit f7cee60 into aws:main May 7, 2025
117 of 120 checks passed
@justsmth justsmth deleted the BIO-datagram branch May 7, 2025 22:44
geedo0 added a commit to geedo0/strongswan that referenced this pull request May 12, 2025
The `crypt` function defined in `openssl_crypter.c` conflicts with the
`crypt` function defined in `unistd.h` and triggers a compilation error
when building against the latest version of AWS-LC. I believe this
[PR](aws/aws-lc#2321) introduced the new
transitive include to `evp.h`.

This PR simply renames the function to avoid the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants