Skip to content

Reintroduce support for validating DNS commonName subjects when name constraints are present. #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025

Conversation

skmcgrail
Copy link
Member

Description of changes:

  • Reverts c67076d which replaced how certificates are handled when there is a DNS-like name in the certificates subject commonName. (Note this doesn't fully restore the original OpenSSL behavior, as that change seems to have been made before upstream made their source available).
  • Reintroduction of the OpenSSL 1.1.1 for identifying DNS-like names in the subject commonName and the ability to use the X509_CHECK_FLAG_NEVER_CHECK_SUBJECT and X509_CHECK_FLAG_ALWAYS_CHECK_SUBJECT flags to check this value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner April 28, 2025 19:32
@skmcgrail skmcgrail changed the title Add back support for validating DNS commonName subjects when name constraints are present. Reintroduce support for validating DNS commonName subjects when name constraints are present. Apr 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 95.55556% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.83%. Comparing base (af5fc97) to head (2f1a498).

Files with missing lines Patch % Lines
crypto/x509/v3_ncons.c 92.59% 4 Missing ⚠️
crypto/x509/v3_utl.c 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             x509    #2376   +/-   ##
=======================================
  Coverage   78.82%   78.83%           
=======================================
  Files         622      622           
  Lines      108113   108154   +41     
  Branches    15347    15362   +15     
=======================================
+ Hits        85219    85261   +42     
+ Misses      22241    22240    -1     
  Partials      653      653           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skmcgrail skmcgrail requested a review from justsmth May 2, 2025 17:54
@skmcgrail skmcgrail force-pushed the name-constraints-subject branch from 51909b5 to d67077f Compare May 7, 2025 20:06
@skmcgrail skmcgrail force-pushed the name-constraints-subject branch from 3c13d2d to 2f1a498 Compare May 7, 2025 20:50
@skmcgrail skmcgrail merged commit fb01b33 into aws:x509 May 8, 2025
111 of 113 checks passed
@skmcgrail skmcgrail deleted the name-constraints-subject branch May 8, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants