-
Notifications
You must be signed in to change notification settings - Fork 132
Reintroduce support for validating DNS commonName subjects when name constraints are present. #2376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## x509 #2376 +/- ##
=======================================
Coverage 78.82% 78.83%
=======================================
Files 622 622
Lines 108113 108154 +41
Branches 15347 15362 +15
=======================================
+ Hits 85219 85261 +42
+ Misses 22241 22240 -1
Partials 653 653 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Apr 30, 2025
justsmth
reviewed
May 1, 2025
This reverts commit c67076d.
51909b5
to
d67077f
Compare
justsmth
approved these changes
May 7, 2025
3c13d2d
to
2f1a498
Compare
samuel40791765
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
X509_CHECK_FLAG_NEVER_CHECK_SUBJECT
andX509_CHECK_FLAG_ALWAYS_CHECK_SUBJECT
flags to check this value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.