-
Notifications
You must be signed in to change notification settings - Fork 132
Simplify urandom and move iOS source into its own file #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
torben-hansen
merged 12 commits into
aws:randomness_generation
from
torben-hansen:ragdoll_simplify_urandom
May 8, 2025
Merged
Simplify urandom and move iOS source into its own file #2379
torben-hansen
merged 12 commits into
aws:randomness_generation
from
torben-hansen:ragdoll_simplify_urandom
May 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #2379 +/- ##
=========================================================
- Coverage 78.74% 78.70% -0.05%
=========================================================
Files 637 637
Lines 109341 109382 +41
Branches 15494 15507 +13
=========================================================
- Hits 86099 86087 -12
- Misses 22519 22568 +49
- Partials 723 727 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All these failures are known errors and some because fixes does not exist on target branch yet. |
skmcgrail
previously approved these changes
May 5, 2025
andrewhop
reviewed
May 6, 2025
skmcgrail
previously approved these changes
May 6, 2025
justsmth
approved these changes
May 7, 2025
skmcgrail
approved these changes
May 8, 2025
andrewhop
approved these changes
May 8, 2025
65a3384
into
aws:randomness_generation
99 of 106 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactor
urandom.c
to be more readable:CCRandomGenerateBytes()
into its own file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.