Skip to content

Fix PQ Integration tests #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Fix PQ Integration tests #2392

merged 2 commits into from
May 5, 2025

Conversation

alexw91
Copy link
Contributor

@alexw91 alexw91 commented May 2, 2025

Issues:

N/A

Description of changes:

The BoringSSL command moved from ${SCRATCH_FOLDER}/boring-ssl-build/tool/bssl to ${SCRATCH_FOLDER}/boring-ssl-build/bssl.

This PR updates the PQ integration tests to validate that required binaries are present before attempting to use them.

Call-outs:

None

Testing:

Tested locally on Ubuntu 22.04 LTS release.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@alexw91 alexw91 requested a review from a team as a code owner May 2, 2025 21:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (ef71b09) to head (30829dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
- Coverage   78.77%   78.75%   -0.02%     
==========================================
  Files         620      620              
  Lines      107961   107961              
  Branches    15329    15331       +2     
==========================================
- Hits        85046    85029      -17     
- Misses      22258    22274      +16     
- Partials      657      658       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkostic dkostic merged commit 4fc362f into aws:main May 5, 2025
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants