Skip to content

Conversation

@nhatnghiho
Copy link
Contributor

Description of changes:

Implement enc CLI with the following options:

  • e
  • d
  • aes-128-cbc
  • K
  • in
  • out
  • iv

Testing:

Unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho requested a review from a team as a code owner December 3, 2025 17:38
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 76.62338% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.23%. Comparing base (f5e4585) to head (d0c9d87).

Files with missing lines Patch % Lines
tool-openssl/enc_test.cc 72.72% 36 Missing ⚠️
tool-openssl/enc.cc 81.81% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   78.22%   78.23%   +0.01%     
==========================================
  Files         683      685       +2     
  Lines      117491   117722     +231     
  Branches    16510    16543      +33     
==========================================
+ Hits        91909    92104     +195     
- Misses      24694    24733      +39     
+ Partials      888      885       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth
Copy link
Contributor

justsmth commented Dec 9, 2025

I believe the Valgrind failure is this one: https://github.com/aws/aws-lc/actions/runs/20031393257/job/57441202249?pr=2877#step:4:1663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants