Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test#3337
Draft
torben-hansen wants to merge 1 commit into
Draft
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test#3337torben-hansen wants to merge 1 commit into
torben-hansen wants to merge 1 commit into
Conversation
torben-hansen
had a problem deploying
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Error
torben-hansen
temporarily deployed
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
July 6, 2026 23:30 — with
GitHub Actions
Inactive
| // |DH_get_rfc7919_2048| declaration can be removed when |DH_get_rfc7919_2048| | ||
| // has been moved to params.c; |DH_get_rfc7919_2048| is used in a bunch of FIPS | ||
| // test code still. | ||
| DH *dh_calculate_rfc7919_from_p(const BN_ULONG data[], size_t data_len); |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'BN_ULONG' [clang-diagnostic-error]
DH *dh_calculate_rfc7919_from_p(const BN_ULONG data[], size_t data_len);
^
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
==========================================
- Coverage 78.21% 78.20% -0.02%
==========================================
Files 693 693
Lines 123900 124048 +148
Branches 17208 17226 +18
==========================================
+ Hits 96910 97013 +103
- Misses 26072 26116 +44
- Partials 918 919 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jakemas
self-requested a review
July 14, 2026 18:39
tianyiy-tim
added a commit
to tianyiy-tim/aws-lc
that referenced
this pull request
Jul 15, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim
added a commit
to tianyiy-tim/aws-lc
that referenced
this pull request
Jul 15, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim
added a commit
to tianyiy-tim/aws-lc
that referenced
this pull request
Jul 15, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim
added a commit
to tianyiy-tim/aws-lc
that referenced
this pull request
Jul 17, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim
added a commit
to tianyiy-tim/aws-lc
that referenced
this pull request
Jul 17, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim
added a commit
to tianyiy-tim/aws-lc
that referenced
this pull request
Jul 17, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
#3335
Description of changes:
Draft for now. Need to review.
Call-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.