Skip to content

Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test#3337

Draft
torben-hansen wants to merge 1 commit into
aws:mainfrom
torben-hansen:github_aws_lc_3335
Draft

Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test#3337
torben-hansen wants to merge 1 commit into
aws:mainfrom
torben-hansen:github_aws_lc_3335

Conversation

@torben-hansen

Copy link
Copy Markdown
Contributor

Issues:

#3335

Description of changes:

Draft for now. Need to review.

Call-outs:

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

// |DH_get_rfc7919_2048| declaration can be removed when |DH_get_rfc7919_2048|
// has been moved to params.c; |DH_get_rfc7919_2048| is used in a bunch of FIPS
// test code still.
DH *dh_calculate_rfc7919_from_p(const BN_ULONG data[], size_t data_len);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unknown type name 'BN_ULONG' [clang-diagnostic-error]

DH *dh_calculate_rfc7919_from_p(const BN_ULONG data[], size_t data_len);
                                      ^

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.26549% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.20%. Comparing base (6283365) to head (acd43ea).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crypto/dh_extra/params.c 88.88% 9 Missing ⚠️
crypto/dh_extra/dh_test.cc 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3337      +/-   ##
==========================================
- Coverage   78.21%   78.20%   -0.02%     
==========================================
  Files         693      693              
  Lines      123900   124048     +148     
  Branches    17208    17226      +18     
==========================================
+ Hits        96910    97013     +103     
- Misses      26072    26116      +44     
- Partials      918      919       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakemas
jakemas self-requested a review July 14, 2026 18:39
tianyiy-tim added a commit to tianyiy-tim/aws-lc that referenced this pull request Jul 15, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim added a commit to tianyiy-tim/aws-lc that referenced this pull request Jul 15, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim added a commit to tianyiy-tim/aws-lc that referenced this pull request Jul 15, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim added a commit to tianyiy-tim/aws-lc that referenced this pull request Jul 17, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim added a commit to tianyiy-tim/aws-lc that referenced this pull request Jul 17, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
tianyiy-tim added a commit to tianyiy-tim/aws-lc that referenced this pull request Jul 17, 2026
Recognise known safe DH groups/primes and short-circuit Diffie-Hellman test (aws#3337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants