Skip to content

Fix S3 event parsing when eventName is present but eventTime is not #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reifiedbeans
Copy link

Motivation and Context

Currently, S3EventNotification::fromJson throws an exception when eventTime is null. This is problematic, since the code intends to allow for this field to be null, but it uses the wrong variable when performing a guard.

Modifications

This patch fixes the null guard by using the correct variable, eventTime, before attempting to parse it as an Instant.

Testing

Built the project locally (couldn't build some modules locally, so I just built the one modified)

./mvnw --projects :s3-event-notifications --also-make install

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@reifiedbeans reifiedbeans marked this pull request as ready for review May 8, 2025 22:46
@reifiedbeans reifiedbeans requested a review from a team as a code owner May 8, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant