Fix S3 event parsing when eventName is present but eventTime is not #6095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently,
S3EventNotification::fromJson
throws an exception wheneventTime
isnull
. This is problematic, since the code intends to allow for this field to benull
, but it uses the wrong variable when performing a guard.Modifications
This patch fixes the
null
guard by using the correct variable,eventTime
, before attempting to parse it as anInstant
.Testing
Built the project locally (couldn't build some modules locally, so I just built the one modified)
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License