Phase 2 , getting Apache 5 compilation and Junit ready along with clearing Checkstyles and spotbug issues #6100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aring Checkstyles and spotbug issues
joviegas
commented
May 15, 2025
...ts/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/MetricReportingTest.java
Outdated
Show resolved
Hide resolved
L-Applin
requested changes
May 15, 2025
| @@ -152,7 +152,9 @@ public void run() { | |||
|
|
|||
| for (Map.Entry<HttpClientConnectionManager, Long> entry : connectionManagers.entrySet()) { | |||
| try { | |||
| entry.getKey().closeIdleConnections(entry.getValue(), TimeUnit.MILLISECONDS); | |||
| entry.getKey().close(CloseMode.GRACEFUL); | |||
There was a problem hiding this comment.
Lets add a todo here to keep track of close_idle_connection_timeout config. We will need to figure out how to support it with Apache5 if we can't do it here.
There was a problem hiding this comment.
Added JAVA-8272 will handle all IM issues in upcoming PR before starting working on test suites
...-client/src/test/java/software/amazon/awssdk/http/apache5/Apache5HttpClientWireMockTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continuation of migrating the Apache 4 client
Motivation and Context
Modifications
Testing
License