Skip to content

Removing S3 dependency in URL client #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2025

Conversation

S-Saranya1
Copy link
Contributor

@S-Saranya1 S-Saranya1 commented Jun 5, 2025

Removing S3 dependency in URL client and moving Url integration tests to s3.

Motivation and Context

The goal is to make regions module depend on IMDS module. Doing that is causing few cyclic test dependency issues, fixing those dependency issues in this PR.

Modifications

Removed dependency of s3 in url-connection-client
Moved the integration tests in url-connection-client to s3-tests
Added dependency of url-connection-client in s3-tests.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner June 5, 2025 18:50
@joviegas
Copy link
Contributor

joviegas commented Jun 5, 2025

The PR description or the change is Removing S3 dependency in URL client and move Url integ test to s3-test.
With this PR we are not adding imds dependency on regions yet, however that is the motivation.

@S-Saranya1 S-Saranya1 changed the title Add IMDS dependency to regions module Removing S3 dependency in URL client Jun 6, 2025
@S-Saranya1 S-Saranya1 added no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required changelog-not-required Indicate changelog entry is not required for a specific PR and removed no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required labels Jun 9, 2025
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we verify integ tests are passing on CodeBuild?

Copy link

sonarqubecloud bot commented Jun 9, 2025

@S-Saranya1
Copy link
Contributor Author

Did we verify integ tests are passing on CodeBuild?

No, I just started it, will merge this PR once it's succeeded.

@S-Saranya1 S-Saranya1 added this pull request to the merge queue Jun 9, 2025
Merged via the queue into master with commit a7801ce Jun 9, 2025
27 of 28 checks passed
@S-Saranya1 S-Saranya1 deleted the somepal/add-imds-dependency-regions branch June 9, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants