Log errors instead of throwing errors for duplicate keys in ImmutableMap #6316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Aug 5, 2025
utils/src/main/java/software/amazon/awssdk/utils/ImmutableMap.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Aug 7, 2025
utils/src/main/java/software/amazon/awssdk/utils/ImmutableMap.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Aug 8, 2025
joviegas
reviewed
Aug 8, 2025
...-enhanced/src/it/java/software/amazon/awssdk/enhanced/dynamodb/ScanQueryIntegrationTest.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Aug 8, 2025
...ests/src/test/java/software/amazon/awssdk/archtests/CodingConventionWithSuppressionTest.java
Outdated
Show resolved
Hide resolved
|
joviegas
approved these changes
Aug 8, 2025
davidh44
added
the
api-surface-area-approved-by-team
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Duplicate endpoint keys set by a service will cause errors to be thrown in
ServiceMetadata's, when puttingServiceEndpointKey's intoImmutableMapModifications
Log errors instead of throwing errors. Keep the first value, ignore the second value
Testing
Updated unit test