Address TODOs #6598
Merged
Address TODOs #6598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
Nov 27, 2025
| * A container for data produced during and as a result of the SigV4 request signing process. | ||
| */ | ||
| @SdkInternalApi | ||
| // TODO(sra-identity-auth): This is currently not @Immutable because signedRequest is a Builder. Is Builder needed? If it could |
Contributor
Author
There was a problem hiding this comment.
Rationale: immutable is acceptable here since it's an internal class IMO. Using immutable everywhere can help performance impact
davidh44
approved these changes
Dec 1, 2025
zoewangg
force-pushed
the
zoewang/fixTodosPart2
branch
from
c38df55 to
85915a5
Compare
zoewangg
added
no-api-surface-area-change
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TODOs and remove obsolete TODOs.
Changelog is not required because there's no customer facing change