Update GeneratePresignUrlInterceptor to use HttpSigner instead of leg… #6619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
added
the
changelog-not-required
zoewangg
commented
Dec 9, 2025
| return doSraPresign(request, selectedAuthScheme, signingRegion, signingClock, expirationDuration); | ||
| } | ||
|
|
||
| // TODO(sra-identity-and-auth): add test case for SELECTED_AUTH_SCHEME case |
Contributor
Author
There was a problem hiding this comment.
Removed this TODO because it's obsolete
alextwoods
approved these changes
Dec 9, 2025
…gacy signer # Conflicts: # services/ec2/src/main/java/software/amazon/awssdk/services/ec2/transform/internal/GeneratePreSignUrlInterceptor.java
zoewangg
force-pushed
the
zoewang/ec2PresignedUrlInterceptorUpdate
branch
from
53ce9d2 to
1e5d651
Compare
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GeneratePresignUrlInterceptor to use HttpSigner instead of legacy signer
I ran integ tests locally and verified it worked.
Similar change has been pushed in #4941
Marked as changelog not required since there's no public customer facing change