-
Notifications
You must be signed in to change notification settings - Fork 1k
Part [1/2] - Generate "Fast" AttributeValue construction methods to circumvent builder pattern #7039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RanVaknin
wants to merge
10
commits into
feature/master/DDB-enhanced-fast-AV-construction-optimization
Choose a base branch
from
rvaknin/av-fast-construct
base: feature/master/DDB-enhanced-fast-AV-construction-optimization
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Part [1/2] - Generate "Fast" AttributeValue construction methods to circumvent builder pattern #7039
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5909d8b
Add generated opt in fast construction factories for DDB AttributeVal…
RanVaknin 8256774
Remove benchmark to use the existing Enhanced Client benchmark instead
RanVaknin e516174
Add FAST_UNSET to avoid repetitive codegen
RanVaknin 10bee2a
Change scope of customization config from per service, to target spec…
RanVaknin 64b5b50
Refactor collection type factories to use FAST_UNSET, codegen guard t…
RanVaknin 47f0dc1
Remove customization to generate boilerplate codegen drift (without o…
RanVaknin 6973318
Add back customization flag to generate only codegen diff relevant to…
RanVaknin 61d311d
Add javadoc and more test coverage
RanVaknin e850265
Remove customization flag to showcase changes in subsequent commit
RanVaknin 128f6fb
Re-enable flag for ease of review of codegen changes
RanVaknin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider add a validation here to make sure the entry resolves to a real union shape? A typo could silently emits nothing and fail downstream. Not a blocker though.