feat(codegen): generate empty SdkWarmUpProvider and META-INF/services registration per service#7085
Open
joviegas wants to merge 2 commits into
Conversation
… registration per service
…g specs implementation where we donot genrate javadocs for generated interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change makes codegen emit a provider plus its
ServiceLoaderregistration in every service module. ThewarmUp()body is empty in this PR; the synthetic priming call is added in a follow-up PR.Modifications
WarmUpProviderSpec: generates<Service>WarmUpProviderin<service>.internal.crac, implementingSdkWarmUpProviderwith an emptywarmUp().WarmUpProviderRegistrationTask: writes the provider's class name intoMETA-INF/services/software.amazon.awssdk.core.crac.SdkWarmUpProvider. Creates the file once, appends per service, skips duplicates.WarmUpProviderTasks: emits both outputs, wired intoAwsGeneratorTasksso every service runs it.Metadata.getFullCracInternalPackageName()andGeneratorPathProvider.getWarmUpProviderDirectory(): resolve the package and output directory.Testing
codegen-generated-classes-testafter Part B that is implementation of actual wampUp api for each services is completed.Screenshots (if appropriate)
Types of changes
License