fix: allow IPv6 EKS Pod Identity host regardless of IMDS endpoint mode#7086
Open
jtuglu1 wants to merge 1 commit into
Open
fix: allow IPv6 EKS Pod Identity host regardless of IMDS endpoint mode#7086jtuglu1 wants to merge 1 commit into
jtuglu1 wants to merge 1 commit into
Conversation
ContainerCredentialsProvider rejects the EKS Pod Identity IPv6 endpoint (http://[fd00:ec2::23]/v1/credentials) unless AWS_EC2_METADATA_SERVICE_ENDPOINT_MODE was explicitly set to IPV6. That variable configures the EC2 IMDS endpoint (169.254.169.254 vs [fd00:ec2::254]) which is (I believe?) a separate subsystem from the container credentials endpoint and EKS Pod Identity never sets it, so it defaults to the IPv4 allowlist. This behavior rejects valid IPv6 loopback hosts. This change aligns the Java SDK with the C++, Python (botocore), Go v2, and JS v3 SDKs, all of which allow the EKS IPv6 host unconditionally. Related issue: aws/containers-roadmap#2683.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContainerCredentialsProvider rejects the EKS Pod Identity IPv6 endpoint (http://[fd00:ec2::23]/v1/credentials) unless AWS_EC2_METADATA_SERVICE_ENDPOINT_MODE was explicitly set to IPV6. That variable configures the EC2 IMDS endpoint (169.254.169.254 vs [fd00:ec2::254]) which is (I believe?) a separate subsystem from the container credentials endpoint and EKS Pod Identity never sets it, so it defaults to the IPv4 allowlist. This behavior rejects valid IPv6 loopback hosts.
This change aligns the Java SDK with the C++, Python (botocore), Go v2, and JS v3 SDKs, all of which allow the EKS IPv6 host unconditionally.
Related issue: aws/containers-roadmap#2683.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License