Skip to content

feat(codegen): fill URI/endpoint-bound members for the CRaC warm-up call and warm sync/async clients independently#7183

Open
joviegas wants to merge 2 commits into
feature/master/crac_auto_priming_supportfrom
joviegas/warmup_codegen_updates_special_cases
Open

feat(codegen): fill URI/endpoint-bound members for the CRaC warm-up call and warm sync/async clients independently#7183
joviegas wants to merge 2 commits into
feature/master/crac_auto_priming_supportfrom
joviegas/warmup_codegen_updates_special_cases

Conversation

@joviegas

@joviegas joviegas commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

The CRaC warm-up selector did not select an operation that has a required member bound to the URI path or to an endpoint context param. These members do not accept null. Some services have this member on every candidate operation. For these services, the selector found no operation. Thus the SDK did not prime the marshalling path or the signing path before the checkpoint.

Also, warmUp() warmed the sync client and the async client in one flow. If one client failed, the other client did not warm.

Modifications

  • Selector (WarmUpOperationSelector): Accept an operation when all of its required URI/endpoint-bound members are of type String. The allDummyMembersAreFillable gate does this check. Add the membersRequiringDummyValue helper and the isArnMember helper.
  • Emitter (WarmUpProviderSpec): Emit a dummy value for each required bound member. Use "warmup" for a plain member. Use an ARN value for an ARN member. Move the client build into the shared clientBuilder helper and the addServiceSpecificOptions helper (bearer token, endpoint-discovery disable). The sync path and the async path share these helpers.
  • Isolation (SdkWarmUpProvider.warmUp(), TargetedWarmUpInvoker): Route both paths through the shared WarmUpDiscovery.runSafely(description, task) helper. The sync client and the async client warm on their own. If one client fails, the SDK writes a warn log and continues to warm the other client.

Modules that always need each fix

Fix A. Dummy value for a required URI-path or endpoint-bound member. These modules have a required member that the marshaller rejects on null. They now get .member("warmup").

These modules need a dummy value for a required URI-path member: apigatewaymanagementapi, iotjobsdataplane, lexruntime, lexruntimev2, quicksight, sagemakerruntime, sagemakerfeaturestoreruntime, workmailmessageflow, ebs, chimesdkmeetings, amplifyuibuilder, marketplacedeployment, eksauth, geomaps, transcribestreaming.

One module needs a dummy value for an endpoint context param:

Module What it needs
s3control Dummy value for the AccountId endpoint context param (validated only as a host label, so "warmup" works)

Fix A (selector gate). No dummy value is possible, so the provider builds the client only.

Module What it needs
cloudfrontkeyvaluestore Its KvsARN is ARN-validated by the endpoint rules (aws.parseArn), so no dummy value works. The selector skips it and generates a client-build-only provider.

Fix B. Bearer-token auth.

Module What it needs
codecatalyst Resolves a token, not sigv4 creds. Emits .tokenProvider(StaticTokenProvider.create(() -> "warmup-dummy-token")) so it does not fall through to the profile/SSO token chain and fail.

Fix C. Endpoint-discovery WARN suppression.

Module What it needs
timestreamwrite Emits .endpointDiscoveryEnabled(false) to stop the client constructor logging a WARN about the endpoint override disabling discovery
timestreamquery Same as above

Testing

  • Junits

License

  • I confirm that this pull request can be released under the Apache 2 license

…all and warm sync/async clients independently
@joviegas
joviegas requested a review from a team as a code owner July 22, 2026 21:53
try {
task.run();
return true;
} catch (RuntimeException | LinkageError e) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour is same ad before, as part of this PR moved it to a function so that this can be resused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant