fix(amazonq): Added end to end UI tests for /test workflow. #5476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randall-Jiang
changed the title
manodnyab
reviewed
Mar 20, 2025
Comment on lines
696
to
720
| async function waitForElementWithText(page, text) { | ||
| await page.waitForFunction( | ||
| (expectedText) => { | ||
| const elements = document.querySelectorAll('*'); | ||
| return Array.from(elements).find(element => | ||
| element.textContent?.trim() === expectedText | ||
| ); | ||
| }, | ||
| {}, | ||
| text | ||
| ); | ||
| } | ||
|
|
||
| async function waitAndGetElementByText(page, text) { | ||
| const element = await page.waitForFunction( | ||
| (expectedText) => { | ||
| const elements = document.querySelectorAll('*'); | ||
| return Array.from(elements).find(element => | ||
| element.textContent?.trim() === expectedText | ||
| ); | ||
| }, | ||
| {}, | ||
| text | ||
| ); | ||
| return element; |
There was a problem hiding this comment.
these functions can be abstracted out and used as utils
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
|
/runUiTest |
|
/runUiTest |
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
|
/runUiTests |
1 similar comment
|
/runUiTests |
|
/runUiTests |
manodnyab
approved these changes
Apr 1, 2025
Comment on lines
697
to
713
| // const feedbackButton = await page.waitForFunction( | ||
| // (expectedText) => { | ||
| // const buttons = document.querySelectorAll('button'); | ||
| // return Array.from(buttons).find(button => | ||
| // button.textContent.includes(expectedText) | ||
| // ); | ||
| // }, | ||
| // { timeout: 4000000 }, | ||
| // "How can we make /test better" | ||
| // ); | ||
| // | ||
| // if (feedbackButton){ | ||
| // console.log("Feedback button found with correct text after error") | ||
| // }else{ | ||
| // console.log("Feedback button not found") | ||
| // throw new Error('Feedback button not found'); | ||
| // } |
There was a problem hiding this comment.
can you please remove this code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Added end to end UI tests for /test workflow.
These tests cover:
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.