feat(amazonq): LSP telemetry/event messages trigger client side telemetry service calls #5511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
reviewed
Mar 26, 2025
| import java.util.concurrent.CompletableFuture | ||
|
|
||
| /** | ||
| * Concrete implementation of [AmazonQLanguageClient] to handle messages sent from server | ||
| */ | ||
| class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageClient { | ||
| override fun telemetryEvent(`object`: Any) { | ||
| println(`object`) | ||
| when (`object`) { | ||
| is MutableMap<*, *> -> handleTelemetryMap(`object`) |
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Outdated
Show resolved
Hide resolved
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Outdated
Show resolved
Hide resolved
| TelemetryService.getInstance().record(project) { | ||
| datum(name) { | ||
| createTime(Instant.now()) | ||
| unit(telemetryMap["unit"] as? MetricUnit ?: MetricUnit.NONE) |
There was a problem hiding this comment.
how does Flare model this event? i'm not sure if Gson will magically deserialize into these types
…olkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt Co-authored-by: Richard Li <[email protected]>
…olkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt Co-authored-by: Richard Li <[email protected]>
samgst-amazon
commented
Mar 26, 2025
| val name = telemetryMap["name"] as? String ?: return | ||
|
|
||
| @Suppress("UNCHECKED_CAST") | ||
| val data = telemetryMap["data"] as? Map<String, Any> ?: return |
There was a problem hiding this comment.
is this the correct action here? are there any telemetry events we want to be emitting that would have no data?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Fixed
Show fixed
Hide fixed
# Conflicts: # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt # plugins/amazonq/shared/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImplTest.kt
rli
reviewed
May 13, 2025
|
|
||
| TelemetryService.getInstance().record(project) { | ||
| datum(name) { | ||
| createTime(Instant.now()) |
There was a problem hiding this comment.
time should be extracted from the metric?
rli
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP client handles telemetry/event messages sent from the server
Types of changes
Description
the generic TelemetryService.record() is used to dynamically send telemetry calls received from the server.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.