Skip to content

fix(amazonq): Add modal notification if Amazon Q Chat is not available #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manodnyab
Copy link
Contributor

@manodnyab manodnyab commented Mar 26, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

JCEF is not compatible in multiple platforms including Android Studio. This change adds a modal informing the user that Chat is incompatible with their current IDE. It provides steps to workaround this issue in case it is in Android Studio.

Screenshot 2025-03-26 at 1 20 39 PM

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab requested review from a team as code owners March 26, 2025 20:28
@manodnyab manodnyab changed the title Fix for Amazon Q chat not compatible in Android Studio fix(amazonq): Fix for Amazon Q chat not compatible in Android Studio Mar 26, 2025
Copy link

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Incorrect string capitalization 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

}

init {
title = AmazonQBundle.message("amazonQChat.incompatible.title")

Check warning

Code scanning / QDJVMC

Incorrect string capitalization Warning

String 'Amazon Q Chat not Supported on this Platform' is not properly capitalized. It should have title capitalization
@@ -1,4 +1,7 @@
action.q.hello.description=Hello description
amazonqChat.incompatible.text=JCEF, a dependency of Amazon Q chat is not supported in {0}
amazonQChat.incomptible.text.fix=<html>To fix this,<ul><li>Click on Help-> Find Actions: Choose Boot runtime for the IDE</li><li>Select the latest JetBrains Runtime JBR with JCEF that matches the default runtime</li></ul></html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,7 @@
action.q.hello.description=Hello description
amazonqChat.incompatible.text=JCEF, a dependency of Amazon Q chat is not supported in {0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
amazonqChat.incompatible.text=JCEF, a dependency of Amazon Q chat is not supported in {0}
amazonqChat.incompatible.text=JCEF, a dependency of Amazon Q Chat is not supported in {0}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe too long? break into 2 lines?

"Webview support is not available"
"{amazonqChat.incompatible.text}"

icon(Messages.getWarningIcon())
label(AmazonQBundle.message("amazonqChat.incompatible.text", ApplicationNamesInfo.getInstance().fullProductName)).bold()
}
row {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rli rli changed the title fix(amazonq): Fix for Amazon Q chat not compatible in Android Studio fix(amazonq): Add modal notification if Amazon Q Chat is not available Mar 26, 2025
@rli
Copy link
Contributor

rli commented Mar 26, 2025

modal address cases: #4124, #4160, #5182, #5048 (double check for more)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants