Skip to content

fix(amazonq): Fix Generate unit tests from right click context menu #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2025

Conversation

manodnyab
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented May 9, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@manodnyab manodnyab changed the title WIP: Fix Generate unit tests from right click context menu fix(amazonq): Fix Generate unit tests from right click context menu May 11, 2025
@manodnyab manodnyab marked this pull request as ready for review May 11, 2025 05:27
@manodnyab manodnyab requested review from a team as code owners May 11, 2025 05:27
/**
* right click -> generate test has no tab id
* we have to manually create one if a testgen tab
* wasn't previously created
Copy link
Contributor

@samgst-amazon samgst-amazon May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean users can have only one Test tab open at a single time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, users will be able to have only one test tab open which is the preexisting behavior

@manodnyab manodnyab merged commit 0ebebe0 into feature/q-lsp-chat May 12, 2025
14 of 16 checks passed
@manodnyab manodnyab deleted the manodnyb/fixGenerateUnitTests branch May 12, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants