fix(amazonq): use user provided node runtime #5768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Fixed
Show fixed
Hide fixed
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Fixed
Show fixed
Hide fixed
rli
reviewed
May 30, 2025
| @@ -372,7 +377,34 @@ private class AmazonQServerInstance(private val project: Project, private val cs | |||
| } | |||
|
|
|||
| val node = if (SystemInfo.isWindows) "node.exe" else "node" | |||
| val cmd = NodeExePatcher.patch(artifact.resolve(node)) | |||
| var nodePath = artifact.resolve(node) | |||
| // download node runtime if it is not found | |||
There was a problem hiding this comment.
we should also search user PATH
There was a problem hiding this comment.
actually we can just test if it works
ExecUtil.execAndGetOutput(GeneralCommandLine(node, "--version"))
or something
There was a problem hiding this comment.
done in latest commit
leigaol
changed the title
rli
reviewed
May 31, 2025
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Outdated
Show resolved
Hide resolved
| project = project, | ||
| listOf( | ||
| NotificationAction.create( | ||
| message("codewhisperer.actions.open_settings.title") |
Check warning
Code scanning / QDJVMC
Incorrect string capitalization Warning
rli
approved these changes
Jun 2, 2025
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Outdated
Show resolved
Hide resolved
|
CI failure: :plugin-toolkit:jetbrains-rider:test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Manually injected download failure / unzip failure of node, then I saw the alert, then I added my own node in settings, then it works.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.