Skip to content

mcp support #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: feature/q-lsp-chat
Choose a base branch
from
Open

mcp support #5770

wants to merge 9 commits into from

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented May 30, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners May 30, 2025 20:09
@@ -174,6 +178,18 @@ object AmazonQChatServer : JsonRpcMethodProvider {
Any::class.java
)

val listMcpServers = JsonRpcRequest(
LIST_MCP_SERVERS_REQUEST_METHOD,
ListMcpServersParams::class.java,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldnt these have just been any?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Can you elaborate on this please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the request/response parameter types can be LspAny because they are pure passthrough?

import software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.chat.Status as ResultStatus
// MCP Server Status
@JsonAdapter(EnumJsonValueAdapter::class)
enum class McpServerStatus(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "McpServerStatus" is never used
import software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.chat.Status as ResultStatus
// MCP Server Status
@JsonAdapter(EnumJsonValueAdapter::class)
enum class McpServerStatus(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used
// MCP Server Status
@JsonAdapter(EnumJsonValueAdapter::class)
enum class McpServerStatus(@JsonValue val repr: String) {
INITIALIZING("textarea"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "INITIALIZING" is never used
@JsonAdapter(EnumJsonValueAdapter::class)
enum class McpServerStatus(@JsonValue val repr: String) {
INITIALIZING("textarea"),
ENABLED("textinput"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "ENABLED" is never used
INITIALIZING("textarea"),
ENABLED("textinput"),
FAILED("failed"),
DISABLED("disabled");

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "DISABLED" is never used
)

// List MCP Servers Result
data class ListMcpServersResult(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "ListMcpServersResult" is never used


// MCP Server Click Result
data class McpServerClickResult(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "McpServerClickResult" is never used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants