-
Notifications
You must be signed in to change notification settings - Fork 252
mcp support #5770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/q-lsp-chat
Are you sure you want to change the base?
mcp support #5770
Conversation
@@ -174,6 +178,18 @@ object AmazonQChatServer : JsonRpcMethodProvider { | |||
Any::class.java | |||
) | |||
|
|||
val listMcpServers = JsonRpcRequest( | |||
LIST_MCP_SERVERS_REQUEST_METHOD, | |||
ListMcpServersParams::class.java, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldnt these have just been any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, Can you elaborate on this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the request/response parameter types can be LspAny
because they are pure passthrough?
import software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.chat.Status as ResultStatus | ||
// MCP Server Status | ||
@JsonAdapter(EnumJsonValueAdapter::class) | ||
enum class McpServerStatus(@JsonValue val repr: String) { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
import software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.chat.Status as ResultStatus | ||
// MCP Server Status | ||
@JsonAdapter(EnumJsonValueAdapter::class) | ||
enum class McpServerStatus(@JsonValue val repr: String) { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
// MCP Server Status | ||
@JsonAdapter(EnumJsonValueAdapter::class) | ||
enum class McpServerStatus(@JsonValue val repr: String) { | ||
INITIALIZING("textarea"), |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
@JsonAdapter(EnumJsonValueAdapter::class) | ||
enum class McpServerStatus(@JsonValue val repr: String) { | ||
INITIALIZING("textarea"), | ||
ENABLED("textinput"), |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
INITIALIZING("textarea"), | ||
ENABLED("textinput"), | ||
FAILED("failed"), | ||
DISABLED("disabled"); |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
) | ||
|
||
// List MCP Servers Result | ||
data class ListMcpServersResult( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
|
||
|
||
// MCP Server Click Result | ||
data class McpServerClickResult( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
* fix: Add mcp: true in the aws Client capabilities when init LSP. * fix: moving mcp config under q
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.