feat(amazonq): Add model selection for agentic chat #5771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuoyaofu
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
Fixed
Show fixed
Hide fixed
andrewyuq
reviewed
May 30, 2025
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Outdated
Show resolved
Hide resolved
andrewyuq
approved these changes
May 31, 2025
…brains into model-selection
ctlai95
reviewed
May 31, 2025
There was a problem hiding this comment.
nit: do we need this? if so, can we make it a little bit more descriptive
ctlai95
reviewed
May 31, 2025
| @@ -400,6 +401,17 @@ class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageC | |||
| return CompletableFuture.completedFuture(Unit) | |||
| } | |||
|
|
|||
| override fun chatOptionsUpdate(params: LSPAny): CompletableFuture<Unit> { | |||
There was a problem hiding this comment.
nit: should we call it sendChatOptionsUpdate to be consistent with sendChatUpdate?
ctlai95
approved these changes
May 31, 2025
manodnyab
reviewed
Jun 2, 2025
| @@ -394,6 +394,8 @@ private handleDocCommand(chatPrompt: ChatPrompt, tabID: string, taskName: string | |||
| loadingChat: true, | |||
| cancelButtonWhenLoading: false, | |||
| }) | |||
| } else { | |||
| this.mynahUI?.updateStore(affectedTabId, { promptInputOptions: [] }) | |||
| @@ -21,6 +21,7 @@ const val CHAT_LINK_CLICK = "aws/chat/linkClick" | |||
| const val CHAT_LIST_CONVERSATIONS = "aws/chat/listConversations" | |||
| const val CHAT_OPEN_TAB = "aws/chat/openTab" | |||
| const val CHAT_PROMPT_OPTION_ACKNOWLEDGED = "chatPromptOptionAcknowledged" | |||
| const val CHAT_OPTIONS_UPDATE_NOTIFICATION = "aws/chat/chatOptionsUpdate" | |||
There was a problem hiding this comment.
nit: alphabetical order of commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Users should be able to select a specific bedrock model for agentic chat.
Adds a dropdown with 3 options: auto, sonnet 3.7 and sonnet 3.5, the selected value gets passed to the model request.
Flare changes: aws/language-servers#1294
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.