Skip to content

feat(amazonq): fallback to bundled flare assets if cannot be downloaded #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025

Conversation

rli
Copy link
Contributor

@rli rli commented May 30, 2025

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli rli requested a review from a team as a code owner May 30, 2025 21:50
@rli rli changed the base branch from feature/q-lsp-chat to rli/download-flare May 30, 2025 21:50
@rli rli changed the title Rli/artifact fallback feat(amazonq): fallback to bundled flare assets if cannot be downloaded May 30, 2025
Copy link

github-actions bot commented May 30, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

return@async artifactPath
} catch(e: Exception) {
logger.warn(e) { "Failed to resolve assets from Flare CDN" }
val path = AwsToolkit.PLUGINS_INFO[AwsPlugin.Q]?.path?.resolve("flare") ?: error("not even bundled")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to notify here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user should not care

Base automatically changed from rli/download-flare to feature/q-lsp-chat June 2, 2025 17:26
@rli rli merged commit 6ef5842 into feature/q-lsp-chat Jun 2, 2025
11 of 16 checks passed
@rli rli deleted the rli/artifact-fallback branch June 2, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants