-
Notifications
You must be signed in to change notification settings - Fork 603
feat(lambda): add progress status item for invoke actions #7188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
return await vscode.debug.startDebugging(folder, finalConfig) | ||
} | ||
) | ||
vscode.window.setStatusBarMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status item disappears as soon as the invoke process complete. Use the vscode.window.setStatusBarMessage()
to show final result and auto disappear after 5 second.
// Use withProgress in the extension host context | ||
await vscode.window.withProgress( | ||
{ | ||
location: vscode.ProgressLocation.Window, | ||
title: localize('AWS.lambda.local.invoke.progressTitle', 'Local Invoke Function'), | ||
cancellable: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vscode.debug.startDebugging already has its own debugger "stop" ui. why are we adding more ui on top of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently allow invocation without debugging. So we should have this an option to stop long-running process. However, supporting cancelling the process required more effort and outside the scope of the current work. We will support it later.
Problem
Currently, both Lambda local invoke web view page and remote web view page does not have any indicator to show if an invocation is running. Without progress indicators, users have no visual feedback when invoking
Lambda functions, which can lead to uncertainty about whether the operation is still processing or has
stalled. Customers depend solely on terminal output to see the progress.
Solution
This PR implements progress status indicators for Lambda invoke actions, enhancing the user experience
by providing visual feedback during Lambda invocation processes.
Changes Overview:
• Added progress status item functionality for both local SAM and remote Lambda invoke actions
• Refactored backend logic by renaming invokeLambda.ts to remoteInvokeBackend.ts for better code
organization
• Updated Vue components to display progress status during invocation
• Consolidated and reorganized test files for better maintainability
• Updated localization strings in package.nls.json to support new UI elements
Testing:
• Consolidate test files to remove duplicated tests.
• Added new tests to verify progress status functionality
• Maintained test coverage for existing functionality
feature/x
branches will not be squash-merged at release time.