Added step for notification for pr creation#49
Merged
Conversation
aderende
reviewed
Sep 17, 2025
| name: Send Notification | ||
| runs-on: ubuntu-latest | ||
| needs: [update-automation, create-pr] | ||
| if: needs.create-pr.outputs.pr-created == 'true' |
Contributor
There was a problem hiding this comment.
nit: create-pr step should fail if pr were never created successfully. If pr were created create-pr step will succeed.
This eliminates the need for PR_CREATED variable, because it's only used to indicate that create-pr finished successfully. There is a built-in mechanism we can use: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#needs-context
something like this:
send-notification:
name: Send Notification
runs-on: ubuntu-latest
needs: [update-automation, create-pr]
if: ${{ success() && needs.create-pr.result == 'success' }}
Contributor
Author
There was a problem hiding this comment.
Removed the redundant variable in the new commit.
aderende
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.