Skip to content

Added step for notification for pr creation#49

Merged
vpaiu merged 3 commits intoaws:mainfrom
vpaiu:create-pr-notification
Sep 17, 2025
Merged

Added step for notification for pr creation#49
vpaiu merged 3 commits intoaws:mainfrom
vpaiu:create-pr-notification

Conversation

@vpaiu
Copy link
Contributor

@vpaiu vpaiu commented Sep 5, 2025

Description of changes:

  • Added job for sending notification in case the PR is created.

Testing:

@vpaiu vpaiu requested a review from a team as a code owner September 5, 2025 14:01
@vpaiu vpaiu closed this Sep 8, 2025
@vpaiu vpaiu deleted the create-pr-notification branch September 8, 2025 07:49
@vpaiu vpaiu restored the create-pr-notification branch September 8, 2025 07:50
@vpaiu vpaiu reopened this Sep 8, 2025
@vpaiu vpaiu had a problem deploying to security-scanning-workflow-env September 10, 2025 10:51 — with GitHub Actions Failure
@vpaiu vpaiu had a problem deploying to security-scanning-workflow-env September 10, 2025 10:51 — with GitHub Actions Failure
name: Send Notification
runs-on: ubuntu-latest
needs: [update-automation, create-pr]
if: needs.create-pr.outputs.pr-created == 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: create-pr step should fail if pr were never created successfully. If pr were created create-pr step will succeed.
This eliminates the need for PR_CREATED variable, because it's only used to indicate that create-pr finished successfully. There is a built-in mechanism we can use: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#needs-context
something like this:

send-notification:
  name: Send Notification
  runs-on: ubuntu-latest
  needs: [update-automation, create-pr]
  if: ${{ success() && needs.create-pr.result == 'success' }}

Copy link
Contributor Author

@vpaiu vpaiu Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the redundant variable in the new commit.

@vpaiu vpaiu had a problem deploying to security-scanning-workflow-env September 17, 2025 10:13 — with GitHub Actions Failure
@vpaiu vpaiu had a problem deploying to security-scanning-workflow-env September 17, 2025 10:13 — with GitHub Actions Failure
@vpaiu vpaiu merged commit ea5abe2 into aws:main Sep 17, 2025
3 of 6 checks passed
@vpaiu vpaiu deleted the create-pr-notification branch September 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants