Adding comprehensive metrics update in update automation workflow #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 26, 2025 11:37
feiyangliu2023
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
azmkercso
reviewed
Sep 30, 2025
…te-automation workflow
feiyangliu2023
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
feiyangliu2023
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
sachinh-amazon
approved these changes
Sep 30, 2025
azmkercso
reviewed
Sep 30, 2025
| needs: [update-automation, build-and-update-package-locks, generate-oss-attribution, create-pr, send-notification] | ||
| environment: update-automation-workflow-env | ||
| if: success() | ||
| if: always() && !failure() && !cancelled() |
Contributor
There was a problem hiding this comment.
Nice catch adding the !cancelled(). It looks like this will work, but the always() seems redundant, because afaik it always resolves to true (ie: <true> && <true|false> && <true|false> )
azmkercso
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently, update automation action only reports metrics when the action fails. However, in order to monitor if scheduled update is in place, there needs to be metrics sent to cloudwatch, no matter if the action successes or fails.
Description of changes:
This PR refactored execution metrics reporting to dynamically handle success and failure cases
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.