Add displayLocation property and inlineEditSupport capability for tab-tab-tab workflow #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…487) * feat(types): add isEdit flag for next edit suggestion support * feat(types): update isEdit to isInlineEdit and remove from InlineCompletionStates
…ility for tab-tab-tab workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Next Edit Predictions (NEP) feature requires support for the tab-tab-tab workflow, which allows users to navigate through a series of related edit suggestions. However, the current implementation lacks the necessary properties and capability flags to support this workflow.
Solution
• Added the displayLocation property to InlineCompletionItemWithReferences with a concise comment explaining its purpose for tab-tab-tab workflow navigation
• Updated the comment for isInlineEdit to be more concise and focused on its functionality
• Added the inlineEditSupport capability to the awsClientCapabilities structure under textDocument.inlineCompletionWithReferences
These changes enable:
The implementation follows the LSP specification pattern for capability negotiation while maintaining backward compatibility with existing clients.
Testing
• Verified the changes compile without errors
• Confirmed the capability structure follows LSP conventions
• Validated the property definitions match the requirements from the NativeUI-POC implementation
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.