[FEAT] Expose Validate DataFrame Schema API - #2
Open
huaziyao wants to merge 14 commits into
Open
Conversation
huaziyao
changed the title
huaziyao
changed the title
huaziyao
marked this pull request as ready for review
February 10, 2022 18:46
chenliu0831
approved these changes
Feb 17, 2022
|
|
||
| # negative validation | ||
| non_matching_df = identity_df.withColumn("ExtraColumn", lit("extraValue")) | ||
| with tc.assertRaises(Py4JJavaError): |
There was a problem hiding this comment.
can we match the exception message as well?
can-sun
requested changes
Feb 22, 2022
can-sun
left a comment
can-sun
left a comment
Contributor
There was a problem hiding this comment.
Can you please rebase your commits?
| val region = featureGroupArnResolver.resolveRegion() | ||
|
|
||
| val describeResponse = getFeatureGroup(featureGroupName) | ||
| validateDataFrameSchemaWithDescription(inputDataFrame, featureGroupArn, describeResponse) |
Contributor
There was a problem hiding this comment.
"Description” looks a little bit confusing, I would recommend to change the method name to something like "validateDataFrameSchemaWithFeatureGroup"
can-sun
added a commit
that referenced
this pull request
Dec 8, 2022
* Add test dependencies for spark connector * Add integration tests * Remove unnecessary code block for integration test * Fix variable name * Install boto3 on EMR * Fix integration test * Fix the iceberg feature group name * Remove validation of iceberg ingestin for now * New fix * Fix the test * Fix the iceberg test * Fix the offline_store_df * Fix offline_store_df #2 * Update for final release * Add more artifacts that should be ignored by Git * Add assembly output to gitignore * Add iceberg-runtime back as dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The validation logic exists as part of the data ingestion. This change separates out the validation logic and expose it on the Scala and Python interface.
Data type conversion was part of validation. This change moves it to its own function.
Unit tests and integration tests are added.
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.