Skip to content

Conversation

@ThirdEyeSqueegee
Copy link
Member

Issue #, if available:
#400, #422

Description of changes:

  • Add CSI Token Requests support
  • Remove create serviceaccounts/token RBAC permission

NOTE: This PR is currently blocked on upstream changes to the Secrets Store CSI Driver: #1622, 1755. Marking this as a draft until those changes are released.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.19463% with 31 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (29cd21b) to head (379e1ba).

Files with missing lines Patch % Lines
auth/auth.go 80.39% 8 Missing and 2 partials ⚠️
server/server.go 82.75% 6 Missing and 4 partials ⚠️
credential_provider/token_cache.go 74.19% 6 Missing and 2 partials ⚠️
provider/secret_descriptor.go 0.00% 2 Missing ⚠️
...ntial_provider/pod_identity_credential_provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   53.78%   57.00%   +3.21%     
==========================================
  Files          11       12       +1     
  Lines         965     1007      +42     
==========================================
+ Hits          519      574      +55     
+ Misses        435      416      -19     
- Partials       11       17       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove RBAC permission from ASM plugin Use CSI TokenRequest for obtaining service account tokens

2 participants