Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): correcting changeset detection #3737

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Vandita2020
Copy link
Contributor

Issue #, if available

Description of changes

With the updates to the parameter values, the changes were not reflected when the changeSet got created, the issue was with the condition used to check if the update is being made.

Previously, the code used type == "Update" to validate if the action was an update, but it should have been changeset_type == "Update".

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Vandita2020 Vandita2020 requested a review from a team as a code owner March 24, 2025 06:59
@Vandita2020 Vandita2020 force-pushed the correcting_changeset branch from ae9ffa3 to 7fe099f Compare March 24, 2025 07:03
@vicheey
Copy link
Contributor

vicheey commented Mar 24, 2025

Do you mind providing PR links to any related changes or bug issues for context?

@valerena
Copy link
Contributor

valerena commented Mar 24, 2025

It's interesting that this is a bug, but it's not related to an issue we discussed offline. So I don't know exactly what this will do (because this only affects SAM's integration tests, and nothing else).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants