fix: rename JSON test fixtures with .. in filename - #680
Open
priyankshah217 wants to merge 1 commit into
Open
Conversation
The JSON-test-suite fixtures n_number_-1.0..json, n_number_-2..json,
and n_structure_angle_bracket_..json contain `..` in their filenames.
golang.org/x/mod/zip's CheckFilePath rejects any path component
containing `..`, which causes module proxies such as Athens to fail
when fetching and caching this module:
unzip ...smithy-go/@v/v1.27.2.zip: malformed file path
"transport/http/protocol/internal/json/testdata/test_parsing/n_number_-1.0..json":
double dot
Drop one of the trailing dots in each filename so the paths pass
module zip validation. These fixtures are loaded by directory walk
in the parsing tests, so no code references need updating.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three JSON-test-suite fixtures in
transport/http/protocol/internal/json/testdata/test_parsing/contain..in their filenames:n_number_-1.0..jsonn_number_-2..jsonn_structure_angle_bracket_..jsongolang.org/x/mod/zip'sCheckFilePathrejects any path component containing.., so module proxies that validate zip contents server-side — notably Athens — fail to fetch and cache this module:This blocks consumers of
github.com/aws/smithy-go(and transitivelyaws-sdk-go-v2) in any environment whose GOPROXY runs Athens or anotherx/mod/zip-based validator.Fix
Drop one of the trailing dots in each filename so the paths pass module zip validation:
n_number_-1.0..json→n_number_-1.0.jsonn_number_-2..json→n_number_-2.jsonn_structure_angle_bracket_..json→n_structure_angle_bracket_.jsonThese fixtures originate from Nicolas Seriot's JSON Parsing Test Suite, where the
..jsonsuffix encodes the malformed numeric/structural input under test. The file contents are unchanged; only the on-disk names change.Test plan
grep -rfinds no Go code references to these fixture filenames — they are discovered by directory walk in the parsing tests, so renaming does not affect test selection...in any path component.🤖 Generated with Claude Code